Ideas

I tried to add graphql types with the apollo codegen and also gql-tada. Both approaches does not handle Union types well as they require explicit typename checks in order to work with TypeScript.

This requires every time a union is use in a query that the developer checks the typename before accessing any of the properties of the data object. This creates unnecessary checks and very verbose code. Unfortunately most of the Storefront API uses union types (for example content, blocks, organization, persons, etc.).

It is probably better to put the queries in seperate files but have the type definition for each query "manually typed". As this is much easier when we know the query to define the possible outcomes of the query.

Defining each query as a single service is probably better (for example homePageService where all the queries for home page is stored). As then we can co-locate the graphql query, the type, aswell as the code for the query itself.